linux-kernel - Re: [PATCH 2/4] fs: drop_caches: fix skipping over shadow cache inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMfYuOJDAqrNyDiV@carbon.dhcp.thefacebook.com>
Date:   Mon, 14 Jun 2021 15:31:20 -0700
From:   Roman Gushchin <guro@...com>
To:     Johannes Weiner <hannes@...xchg.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Tejun Heo <tj@...nel.org>, <linux-mm@...ck.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-team@...com>
Subject: Re: [PATCH 2/4] fs: drop_caches: fix skipping over shadow cache
 inodes

On Mon, Jun 14, 2021 at 05:19:02PM -0400, Johannes Weiner wrote:
> When drop_caches truncates the page cache in an inode it also includes
> any shadow entries for evicted pages. However, there is a preliminary
> check on whether the inode has pages: if it has *only* shadow entries,
> it will skip running truncation on the inode and leave it behind.
> 
> Fix the check to mapping_empty(), such that it runs truncation on any
> inode that has cache entries at all.
> 
> Reported-by: Roman Gushchin <guro@...com>
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>

Acked-by: Roman Gushchin <guro@...com>

Thanks!