linux-kernel - Re: [PATCH] habanalabs: Fix an error handling path in 'hl_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf109JLqs+Qb5MUDEjG6EXK09JmH+bJjDXvLhNXOrr2aF3A@mail.gmail.com>
Date:   Mon, 14 Jun 2021 11:48:49 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Oded Gabbay <ogabbay@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ofir Bitton <obitton@...ana.ai>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        farah kassabri <fkassabri@...ana.ai>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()'

On Sat, Jun 12, 2021 at 8:42 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/misc/habanalabs/common/habanalabs_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
> index 64d1530db985..d15b912a347b 100644
> --- a/drivers/misc/habanalabs/common/habanalabs_drv.c
> +++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
> @@ -464,6 +464,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
>         return 0;
>
>  disable_device:
> +       pci_disable_pcie_error_reporting(pdev);
>         pci_set_drvdata(pdev, NULL);
>         destroy_hdev(hdev);
>
> --
> 2.30.2
>

Thanks for catching it.
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>

Applied to -next.
Oded