linux-kernel - Re: [PATCH] soc: mediatek: pwarp: delete confusing comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d23e965b271fea96b75bf72b888eb281e514237e.camel@mediatek.com>
Date:   Mon, 14 Jun 2021 17:43:29 +0800
From:   James Lo <james.lo@...iatek.com>
To:     <matthias.bgg@...nel.org>
CC:     <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH] soc: mediatek: pwarp: delete confusing comments


Thank you for your kind assistance.

Many thanks
James Lo


On Fri, 2021-06-11 at 13:13 +0200, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <matthias.bgg@...il.com>
> 
> Comments sugguest that MT8195 arb_en_all and int_en_all values need
> to
> be confirmed. But actually these values are correct.
> 
> Suggested-by: James Lo <james.lo@...iatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
> 
> ---
> 
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 952bc554f443..118eb4acdeb6 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
> pwrap_mt8183 = {
>  static struct pmic_wrapper_type pwrap_mt8195 = {
>  	.regs = mt8195_regs,
>  	.type = PWRAP_MT8195,
> -	.arb_en_all = 0x777f, /* NEED CONFIRM */
> -	.int_en_all = 0x180000, /* NEED CONFIRM */
> +	.arb_en_all = 0x777f,
> +	.int_en_all = 0x180000,
>  	.int1_en_all = 0,
>  	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>  	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,