linux-kernel - Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0218984d-3cf9-1fc4-9f11-81a4e7df956d@somainline.org>
Date:   Mon, 14 Jun 2021 13:49:08 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     sbhanu@...eaurora.org
Cc:     adrian.hunter@...el.com, ulf.hansson@...aro.org,
        robh+dt@...nel.org, asutoshd@...eaurora.org,
        stummala@...eaurora.org, vbadigan@...eaurora.org,
        rampraka@...eaurora.org, sayalil@...eaurora.org,
        sartgarg@...eaurora.org, rnayak@...eaurora.org,
        saiprakash.ranjan@...eaurora.org, sibis@...eaurora.org,
        okukatla@...eaurora.org, djakov@...nel.org, cang@...eaurora.org,
        pragalla@...eaurora.org, nitirawa@...eaurora.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        agross@...nel.org, bjorn.andersson@...aro.org
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and
 Sd card


On 14.06.2021 13:44, sbhanu@...eaurora.org wrote:
> On 2021-06-10 13:24, Konrad Dybcio wrote:
>> Hi,
>>
>>
>>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>> @@ -701,8 +701,9 @@
>>>              interrupt-names = "hc_irq", "pwr_irq";
>>>
>>>              clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>>> -                    <&gcc GCC_SDCC1_AHB_CLK>;
>>> -            clock-names = "core", "iface";
>>> +                    <&gcc GCC_SDCC1_AHB_CLK>,
>>> +                    <&rpmhcc RPMH_CXO_CLK>;
>>
>> Don't these clocks fit in 100 chars?
> These two clocks can fit in 100 chars but we have 3 clocks they don't fit in 100 chars.

You're right.


With the space before xo,

Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>


Konrad