[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b3ea2ad6-6341-df56-9d09-e3e832f8f316@baylibre.com>
Date: Mon, 14 Jun 2021 15:08:46 +0200
From: Neil Armstrong <narmstrong@...libre.com>
To: zpershuai <zpershuai@...il.com>, Mark Brown <broonie@...nel.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] spi: meson-spicc: fix a wrong goto jump for
avoiding memory leak.
Hi,
On 13/06/2021 07:29, zpershuai wrote:
> In meson_spifc_probe function, when enable the device pclk clock is
> error, it should use clk_disable_unprepare to release the core clock.
>
> Signed-off-by: zpershuai <zpershuai@...il.com>
> ---
> drivers/spi/spi-meson-spicc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index d675334..b2c4621 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -725,7 +725,7 @@ static int meson_spicc_probe(struct platform_device *pdev)
> ret = clk_prepare_enable(spicc->pclk);
> if (ret) {
> dev_err(&pdev->dev, "pclk clock enable failed\n");
> - goto out_master;
> + goto out_core_clk;
> }
>
> device_reset_optional(&pdev->dev);
> @@ -764,9 +764,11 @@ static int meson_spicc_probe(struct platform_device *pdev)
> return 0;
>
> out_clk:
> - clk_disable_unprepare(spicc->core);
> clk_disable_unprepare(spicc->pclk);
>
> +out_core_clk:
> + clk_disable_unprepare(spicc->core);
> +
> out_master:
> spi_master_put(master);
>
>
Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
Powered by blists - more mailing lists