linux-kernel - Re: [PATCH] mm: memcontrol: Remove trailing semicolon in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 14 Jun 2021 17:15:36 -0700
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Huilong Deng <denghuilong@...rlc.com>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Roman Gushchin <guro@...com>
Subject: Re: [PATCH] mm: memcontrol: Remove trailing semicolon in macros

+lkml and linux-mm

On Mon, Jun 14, 2021 at 2:15 AM Huilong Deng <denghuilong@...rlc.com> wrote:
>
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@...rlc.com>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>

> ---
>  include/linux/memcontrol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 3cc18c2176e7..1c1b11530ab6 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -192,7 +192,7 @@ enum memcg_kmem_state {
>  struct memcg_padding {
>         char x[0];
>  } ____cacheline_internodealigned_in_smp;
> -#define MEMCG_PADDING(name)      struct memcg_padding name;
> +#define MEMCG_PADDING(name)      struct memcg_padding name
>  #else
>  #define MEMCG_PADDING(name)
>  #endif
> --
> 2.31.1
>
>
>