[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0b012d77-8d61-f852-f455-8b6cceb03ebf@somainline.org>
Date: Tue, 15 Jun 2021 16:53:41 +0200
From: Konrad Dybcio <konrad.dybcio@...ainline.org>
To: Bhupesh Sharma <bhupesh.sharma@...aro.org>,
linux-arm-msm@...r.kernel.org
Cc: bhupesh.linux@...il.com, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Vinod Koul <vkoul@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Andy Gross <agross@...nel.org>
Subject: Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file
Hi,
> +
> + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> +
> + vcc-supply = <&vreg_l10a_2p96>;
> + vcc-max-microamp = <750000>;
> + vccq-supply = <&vreg_l5c_1p2>;
> + vccq-max-microamp = <700000>;
> + vccq2-supply = <&vreg_s4a_1p8>;
> + vccq2-max-microamp = <750000>;
You need to add "regulator-allow-set-load;" to the mentioned supplies,
as you're controlling the amperage here.
> +};
> +
> +&ufs_mem_phy {
> + status = "okay";
> +
> + vdda-phy-supply = <&vreg_l8c_1p2>;
> + vdda-max-microamp = <87100>;
> + vdda-pll-supply = <&vreg_l5a_0p88>;
> + vdda-pll-max-microamp = <18300>;
Ditto
Konrad
Powered by blists - more mailing lists