linux-kernel - Re: [PATCH 3/3] mcb: Remove trailing semicolon in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMjLuWRuRuMiIBjv@kroah.com>
Date:   Tue, 15 Jun 2021 17:48:09 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johannes Thumshirn <johannes.thumshirn@....com>
Cc:     linux-kernel@...r.kernel.org,
        Huilong Deng <denghuilong@...rlc.com>,
        Johannes Thumshirn <jth@...nel.org>
Subject: Re: [PATCH 3/3] mcb: Remove trailing semicolon in macros

On Tue, Jun 15, 2021 at 11:55:30PM +0900, Johannes Thumshirn wrote:
> From: Huilong Deng <denghuilong@...rlc.com>
> 
> Macros should not use a trailing semicolon.
> 
> Signed-off-by: Huilong Deng <denghuilong@...rlc.com>
> Signed-off-by: Johannes Thumshirn <jth@...nel.org>
> ---
>  include/linux/mcb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mcb.h b/include/linux/mcb.h
> index 71dd10a3d928..f6efb16f9d1b 100644
> --- a/include/linux/mcb.h
> +++ b/include/linux/mcb.h
> @@ -120,7 +120,7 @@ extern int __must_check __mcb_register_driver(struct mcb_driver *drv,
>  	__mcb_register_driver(driver, THIS_MODULE, KBUILD_MODNAME)
>  extern void mcb_unregister_driver(struct mcb_driver *driver);
>  #define module_mcb_driver(__mcb_driver)		\
> -	module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver);
> +	module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver)
>  extern void mcb_bus_add_devices(const struct mcb_bus *bus);
>  extern int mcb_device_register(struct mcb_bus *bus, struct mcb_device *dev);
>  extern struct mcb_bus *mcb_alloc_bus(struct device *carrier);
> -- 
> 2.31.1
> 

I've applied this one, feel free to resend the first 2 as emails.

thanks,

greg k-h