linux-kernel - Re: [PATCH] regulator: rt6160: Revert chagne and fix vsel high/low suspend voltage logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADiBU39QEM3srCRM_9sevVNRi4EK95MTq60w-KSgUoqv_92w5A@mail.gmail.com>
Date:   Wed, 16 Jun 2021 00:35:55 +0800
From:   ChiYuan Huang <u0084500@...il.com>
To:     Mark Brown <broonie@...nel.org>, axel.lin@...ics.com
Cc:     lgirdwood@...il.com, lkml <linux-kernel@...r.kernel.org>,
        ChiYuan Huang <cy_huang@...htek.com>
Subject: Re: [PATCH] regulator: rt6160: Revert chagne and fix vsel high/low
 suspend voltage logic

Hi,
I may misunderstand logic in suspend voltage.

The vsel active level is for the normal voltage, the opposite level is
the suspend voltage.

In the suspend voltage callback, I wrote donw the wrong logic.
This patch is to fix it and reverse Axel's change.
I need vsel_active_low variable in suspend voltage callback, not just in local.

cy_huang <u0084500@...il.com> 於 2021年6月16日 週三 上午12:28寫道：
>
> From: ChiYuan Huang <cy_huang@...htek.com>
>
> Revert change and fix vsel logic in suspend voltage logic.
>
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
>  drivers/regulator/rt6160-regulator.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/regulator/rt6160-regulator.c b/drivers/regulator/rt6160-regulator.c
> index ccd023d..1cdb1f4 100644
> --- a/drivers/regulator/rt6160-regulator.c
> +++ b/drivers/regulator/rt6160-regulator.c
> @@ -42,6 +42,7 @@ struct rt6160_priv {
>         struct regulator_desc desc;
>         struct gpio_desc *enable_gpio;
>         struct regmap *regmap;
> +       bool vsel_active_low;
>         bool enable_state;
>  };
>
> @@ -127,15 +128,19 @@ static unsigned int rt6160_get_mode(struct regulator_dev *rdev)
>
>  static int rt6160_set_suspend_voltage(struct regulator_dev *rdev, int uV)
>  {
> +       struct rt6160_priv *priv = rdev_get_drvdata(rdev);
>         struct regmap *regmap = rdev_get_regmap(rdev);
> +       unsigned int reg = RT6160_REG_VSELH;
>         int vsel;
>
>         vsel = regulator_map_voltage_linear(rdev, uV, uV);
>         if (vsel < 0)
>                 return vsel;
>
> -       return regmap_update_bits(regmap, rdev->desc->vsel_reg,
> -                                 RT6160_VSEL_MASK, vsel);
> +       if (!priv->vsel_active_low)
> +               reg = RT6160_REG_VSELL;
> +
> +       return regmap_update_bits(regmap, reg, RT6160_VSEL_MASK, vsel);
>  }
>
>  static int rt6160_get_error_flags(struct regulator_dev *rdev, unsigned int *flags)
> @@ -223,7 +228,6 @@ static int rt6160_probe(struct i2c_client *i2c)
>         struct rt6160_priv *priv;
>         struct regulator_config regulator_cfg = {};
>         struct regulator_dev *rdev;
> -       bool vsel_active_low;
>         unsigned int devid;
>         int ret;
>
> @@ -231,8 +235,7 @@ static int rt6160_probe(struct i2c_client *i2c)
>         if (!priv)
>                 return -ENOMEM;
>
> -       vsel_active_low =
> -               device_property_present(&i2c->dev, "richtek,vsel-active-low");
> +       priv->vsel_active_low = device_property_present(&i2c->dev, "richtek,vsel-active-low");
>
>         priv->enable_gpio = devm_gpiod_get_optional(&i2c->dev, "enable", GPIOD_OUT_HIGH);
>         if (IS_ERR(priv->enable_gpio)) {
> @@ -264,10 +267,7 @@ static int rt6160_probe(struct i2c_client *i2c)
>         priv->desc.owner = THIS_MODULE;
>         priv->desc.min_uV = RT6160_VOUT_MINUV;
>         priv->desc.uV_step = RT6160_VOUT_STPUV;
> -       if (vsel_active_low)
> -               priv->desc.vsel_reg = RT6160_REG_VSELL;
> -       else
> -               priv->desc.vsel_reg = RT6160_REG_VSELH;
> +       priv->desc.vsel_reg = RT6160_REG_VSELH;
>         priv->desc.vsel_mask = RT6160_VSEL_MASK;
>         priv->desc.n_voltages = RT6160_N_VOUTS;
>         priv->desc.ramp_reg = RT6160_REG_CNTL;
> @@ -276,6 +276,8 @@ static int rt6160_probe(struct i2c_client *i2c)
>         priv->desc.n_ramp_values = ARRAY_SIZE(rt6160_ramp_tables);
>         priv->desc.of_map_mode = rt6160_of_map_mode;
>         priv->desc.ops = &rt6160_regulator_ops;
> +       if (priv->vsel_active_low)
> +               priv->desc.vsel_reg = RT6160_REG_VSELL;
>
>         regulator_cfg.dev = &i2c->dev;
>         regulator_cfg.of_node = i2c->dev.of_node;
> --
> 2.7.4
>