linux-kernel - Re: [PATCH v6 2/9] dt-bindings: touchscreen: Initial commit of wacom,generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMjbUQLT+HMfO77+@google.com>
Date:   Tue, 15 Jun 2021 09:54:41 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     linux-input@...r.kernel.org, linux-imx@....com,
        pinglinux@...il.com, tatsunosuke.tobita@...om.com,
        junkpainting@...il.com, ping.cheng@...om.com,
        linux-kernel@...r.kernel.org, alistair23@...il.com,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v6 2/9] dt-bindings: touchscreen: Initial commit of
 wacom,generic

Hi Alistair,

On Tue, Jun 15, 2021 at 08:30:07PM +1000, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair@...stair23.me>

Please also send DT bindings to Rob Herring <robh+dt@...nel.org> and
devicetree@...r.kernel.org.

> ---
>  .../input/touchscreen/wacom,generic.yaml      | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> new file mode 100644
> index 000000000000..68f3f5271b77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/wacom,generic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wacom I2C Controller
> +
> +maintainers:
> +  - Alistair Francis <alistair@...stair23.me>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    const: wacom,generic

This is not an acceptable DT compatible. This needs to be a particular
model of the controller, preferably the first one that supports this
protocol.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Power Supply
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include "dt-bindings/interrupt-controller/irq.h"
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        digitiser@9 {
> +                compatible = "wacom,generic";
> +                reg = <0x9>;
> +                interrupt-parent = <&gpio1>;
> +                interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +                vdd-supply = <&reg_touch>;
> +        };
> +    };
> -- 
> 2.31.1
> 

Thanks.

-- 
Dmitry