linux-kernel - Re: [RFC PATCH 64/67] KVM: TDX: Add "basic" support for building and running Trust Domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210615011042.GA4075334@private.email.ne.jp>
Date:   Mon, 14 Jun 2021 18:10:42 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Erdem Aktas <erdemaktas@...gle.com>
Cc:     "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, x86 <x86@...nel.org>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        isaku.yamahata@...il.com,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Xiaoyao Li <xiaoyao.li@...el.com>,
        Kai Huang <kai.huang@...ux.intel.com>,
        Isaku Yamahata <isaku.yamahata@...ux.intel.com>
Subject: Re: [RFC PATCH 64/67] KVM: TDX: Add "basic" support for building and
 running Trust Domains

On Thu, Jun 10, 2021 at 07:33:29PM -0700,
Erdem Aktas <erdemaktas@...gle.com> wrote:

> some more feedback on KVM_TDX_INIT_MEM_REGION:
> 
> KVM_TDX_INIT_MEM_REGION requires a source and destination address
> which is a little counterintuitive (debatable). I think this requires
> better documentation to explain the usage better. I was wrongly
> expecting to provide the guest memory which has the code as a pointer
> and expecting it to be in-place measured and encrypted.
> 
> KVM_TDX_INIT_MEM_REGION crashes the host when:
> * Target gpa is not valid or not backed by a page
> * When source and destination overlap


Thanks for feedback.
On next respin, I'm going to document new API more.

-- 
Isaku Yamahata <isaku.yamahata@...il.com>