linux-kernel - Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfO5p-SpDWhJ+BFuG3-2YW+4-rBn-SLR2s0z8Po-CHcqA@mail.gmail.com>
Date:   Tue, 15 Jun 2021 22:50:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "jaz@...ihalf.com" <jaz@...ihalf.com>,
        "gjb@...ihalf.com" <gjb@...ihalf.com>,
        "upstream@...ihalf.com" <upstream@...ihalf.com>,
        "Samer.El-Haj-Mahmoud@....com" <Samer.El-Haj-Mahmoud@....com>,
        "jon@...id-run.com" <jon@...id-run.com>
Subject: Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support

On Tue, Jun 15, 2021 at 6:09 PM Marcin Wojtas <mw@...ihalf.com> wrote:
> niedz., 13 cze 2021 o 22:08 Andy Shevchenko
> <andy.shevchenko@...il.com> napisał(a):
> > On Sunday, June 13, 2021, Andrew Lunn <andrew@...n.ch> wrote:

> > The better approach is to switch to devm_get_clk_optional() as I have done in several drivers, IIRC recently in mvpp2
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=cf3399b731d36bc780803ff63e4d480a1efa33ac
>
> Yes, this would be a nice improvement, however the
> devm_get_clk_optional requires clock name (type char *) - mvmdio uses
> raw indexes, so this helper unfortunately seems to be not applicable.

As far as I can read the code it smells like devm_clk_bulk_get_optional().
Am I mistaken?

-- 
With Best Regards,
Andy Shevchenko