linux-kernel - Re: [PATCH 22/28] staging: rtl8188eu: remove all DBG_88E calls from hal/usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMkWviuAT/U/hbc3@KernelVM>
Date:   Tue, 15 Jun 2021 22:08:14 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 22/28] staging: rtl8188eu: remove all DBG_88E calls from
 hal/usb_halinit.c

On Tue, Jun 15, 2021 at 03:41:59PM +0300, Dan Carpenter wrote:
> On Tue, Jun 15, 2021 at 01:15:01AM +0100, Phillip Potter wrote:
> > @@ -1685,8 +1658,6 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
> >  					if (!(usb_read32(Adapter, REG_RXPKT_NUM) & RXDMA_IDLE))
> >  						break;
> >  				} while (trycnt--);
> > -				if (trycnt == 0)
> > -					DBG_88E("Stop RX DMA failed......\n");
> 
> Not related to your patch but this loop will exit with trycnt == -1 not
> 0.
> 
> There should be a Smatch warning for this.  Also Smatch doesn't handle
> while count down loops very well...  It takes the short cut of
> assuming that all do while loops have a break statement.
> 
> regards,
> dan carpenter
> 
> >  
> >  				/* RQPN Load 0 */
> >  				usb_write16(Adapter, REG_RQPN_NPQ, 0x0);
> 

Dear Dan,

Thanks for your feedback, I will try and take a look at this.

Regards,
Phil