linux-kernel - Re: [PATCH v3 0/2] Add Ingenic SoCs MAC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 17:03:31 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     patchwork-bot+netdevbpf@...nel.org,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Giuseppe CAVALLARO <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@...md-mailman.stormreply.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com,
        周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Subject: Re: [PATCH v3 0/2] Add Ingenic SoCs MAC support.

On Mon, Jun 14, 2021 at 2:20 PM <patchwork-bot+netdevbpf@...nel.org> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> > v2->v3:
> > 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> > 2.Change tx clk delay and rx clk delay from hardware value to ps.
> > 3.return -EINVAL when a unsupported value is encountered when
> >   parsing the binding.
> > 4.Simplify the code of the RGMII part of X2000 SoC according to
> >   Andrew Lunn’s suggestion.
> > 5.Follow the example of "dwmac-mediatek.c" to improve the code
> >   that handles delays according to Andrew Lunn’s suggestion.
> >
> > [...]
>
> Here is the summary with links:
>   - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
>     https://git.kernel.org/netdev/net-next/c/3b8401066e5a
>   - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
>     https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7

Perhaps 3 hours is not sufficient time to review. It may be a v3, but
the binding appears to have changed quite a bit in addition to being
broken.

Rob