[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210615010856.GA630506@MiWiFi-R3L-srv>
Date: Tue, 15 Jun 2021 09:08:56 +0800
From: Baoquan He <bhe@...hat.com>
To: Jonathan Corbet <corbet@....net>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
kexec@...ts.infradead.org, akpm@...ux-foundation.org,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Michael Ellerman <mpe@...erman.id.au>,
Hari Bathini <hbathini@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ibm.com>,
Russell King <linux@...linux.org.uk>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
"H. Peter Anvin" <hpa@...or.com>, vgoyal@...hat.com,
x86@...nel.org, Eric Biederman <ebiederm@...ssion.com>,
dyoung@...hat.com
Subject: Re: [PATCH v3] Documentation: kdump: update kdump guide
On 06/13/21 at 05:44pm, Jonathan Corbet wrote:
> Jonathan Corbet <corbet@....net> writes:
>
> > Baoquan He <bhe@...hat.com> writes:
> >
> >> Some parts of the guide are aged, hence need be updated.
> >>
> >> 1) The backup area of the 1st 640K on X86_64 has been removed
> >> by below commits, update the description accordingly.
> >>
> >> commit 7c321eb2b843 ("x86/kdump: Remove the backup region handling")
> >> commit 6f599d84231f ("x86/kdump: Always reserve the low 1M when the crashkernel option is specified")
> >>
> >> 2) Sort out the descripiton of "crashkernel syntax" part.
> >>
> >> 3) And some other minor cleanups.
> >>
> >> Signed-off-by: Baoquan He <bhe@...hat.com>
> >
> > Applied, thanks.
>
> Actually, this patch added a docs build warning:
>
> /stuff/k/git/kernel/Documentation/admin-guide/kdump/kdump.rst:286: WARNING: Literal block ends without a blank line; unexpected unindent.
>
> I've gone ahead and inserted the blank line to fix this. In the future,
> please build-test your changes to make sure that you are not adding new
> warnings.
Thanks, jon. I didn't know doc change can cause build failure, so didn't
build. Will remember this.
Powered by blists - more mailing lists