linux-kernel - Re: [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29287300-6b6b-1773-a950-61ea20f1959c@huawei.com>
Date:   Tue, 15 Jun 2021 10:00:29 +0800
From:   "libaokun (A)" <libaokun1@...wei.com>
To:     <arnd@...db.de>, <mpe@...erman.id.au>, <benh@...nel.crashing.org>,
        <paulus@...ba.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <linux-kernel@...r.kernel.org>
CC:     <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>,
        <yangjihong1@...wei.com>, <yukuai3@...wei.com>
Subject: Re: [PATCH -next] powerpc/spider-pci: Remove set but not used
 variable 'val'

ping

在 2021/6/1 16:53, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
>   arch/powerpc/platforms/cell/spider-pci.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c
> index 93ea41680f54..a1c293f42a1f 100644
> --- a/arch/powerpc/platforms/cell/spider-pci.c
> +++ b/arch/powerpc/platforms/cell/spider-pci.c
> @@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
>   static void spiderpci_io_flush(struct iowa_bus *bus)
>   {
>   	struct spiderpci_iowa_private *priv;
> -	u32 val;
>   
>   	priv = bus->private;
> -	val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
> +	in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
>   	iosync();
>   }
>