| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jun 2021 11:06:11 +0800
From: kernel test robot <lkp@...el.com>
To: Mark Rutland <mark.rutland@....com>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:7071:13:
warning: stack frame size of 2080 bytes in function
'mlxsw_sp_router_fib_event_work'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 009c9aa5be652675a06d5211e1640e02bbb1c33d
commit: 997acaf6b4b59c6a9c259740312a69ea549cc684 lockdep: report broken irq restoration
date: 5 months ago
config: powerpc-randconfig-r023-20210615 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=997acaf6b4b59c6a9c259740312a69ea549cc684
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 997acaf6b4b59c6a9c259740312a69ea549cc684
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:4:
In file included from include/linux/kernel.h:11:
In file included from include/linux/bitops.h:32:
In file included from arch/powerpc/include/asm/bitops.h:62:
arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
#define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
^
<built-in>:309:9: note: previous definition is here
#define __lwsync __builtin_ppc_lwsync
^
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:7071:13: warning: stack frame size of 2080 bytes in function 'mlxsw_sp_router_fib_event_work' [-Wframe-larger-than=]
static void mlxsw_sp_router_fib_event_work(struct work_struct *work)
^
2 warnings generated.
vim +/mlxsw_sp_router_fib_event_work +7071 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
d42b0965b1d4fe Yotam Gigi 2017-09-27 7070
c1b290d594a12b Jiri Pirko 2020-11-10 @7071 static void mlxsw_sp_router_fib_event_work(struct work_struct *work)
c1b290d594a12b Jiri Pirko 2020-11-10 7072 {
c1b290d594a12b Jiri Pirko 2020-11-10 7073 struct mlxsw_sp_router *router = container_of(work, struct mlxsw_sp_router, fib_event_work);
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7074 struct mlxsw_sp_fib_entry_op_ctx *op_ctx = router->ll_op_ctx;
c1b290d594a12b Jiri Pirko 2020-11-10 7075 struct mlxsw_sp *mlxsw_sp = router->mlxsw_sp;
505cd65c66e822 Jiri Pirko 2020-11-10 7076 struct mlxsw_sp_fib_event *next_fib_event;
505cd65c66e822 Jiri Pirko 2020-11-10 7077 struct mlxsw_sp_fib_event *fib_event;
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7078 int last_family = AF_UNSPEC;
c1b290d594a12b Jiri Pirko 2020-11-10 7079 LIST_HEAD(fib_event_queue);
c1b290d594a12b Jiri Pirko 2020-11-10 7080
c1b290d594a12b Jiri Pirko 2020-11-10 7081 spin_lock_bh(&router->fib_event_queue_lock);
c1b290d594a12b Jiri Pirko 2020-11-10 7082 list_splice_init(&router->fib_event_queue, &fib_event_queue);
c1b290d594a12b Jiri Pirko 2020-11-10 7083 spin_unlock_bh(&router->fib_event_queue_lock);
c1b290d594a12b Jiri Pirko 2020-11-10 7084
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7085 /* Router lock is held here to make sure per-instance
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7086 * operation context is not used in between FIB4/6 events
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7087 * processing.
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7088 */
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7089 mutex_lock(&router->lock);
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7090 mlxsw_sp_fib_entry_op_ctx_clear(op_ctx);
505cd65c66e822 Jiri Pirko 2020-11-10 7091 list_for_each_entry_safe(fib_event, next_fib_event,
505cd65c66e822 Jiri Pirko 2020-11-10 7092 &fib_event_queue, list) {
505cd65c66e822 Jiri Pirko 2020-11-10 7093 /* Check if the next entry in the queue exists and it is
505cd65c66e822 Jiri Pirko 2020-11-10 7094 * of the same type (family and event) as the currect one.
505cd65c66e822 Jiri Pirko 2020-11-10 7095 * In that case it is permitted to do the bulking
505cd65c66e822 Jiri Pirko 2020-11-10 7096 * of multiple FIB entries to a single register write.
505cd65c66e822 Jiri Pirko 2020-11-10 7097 */
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7098 op_ctx->bulk_ok = !list_is_last(&fib_event->list, &fib_event_queue) &&
505cd65c66e822 Jiri Pirko 2020-11-10 7099 fib_event->family == next_fib_event->family &&
505cd65c66e822 Jiri Pirko 2020-11-10 7100 fib_event->event == next_fib_event->event;
54ff9dbbb96f7e Jiri Pirko 2020-12-14 7101 op_ctx->event = fib_event->event;
505cd65c66e822 Jiri Pirko 2020-11-10 7102
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7103 /* In case family of this and the previous entry are different, context
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7104 * reinitialization is going to be needed now, indicate that.
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7105 * Note that since last_family is initialized to AF_UNSPEC, this is always
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7106 * going to happen for the first entry processed in the work.
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7107 */
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7108 if (fib_event->family != last_family)
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7109 op_ctx->initialized = false;
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7110
c1b290d594a12b Jiri Pirko 2020-11-10 7111 switch (fib_event->family) {
c1b290d594a12b Jiri Pirko 2020-11-10 7112 case AF_INET:
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7113 mlxsw_sp_router_fib4_event_process(mlxsw_sp, op_ctx,
2d5bd7a111ca08 Jiri Pirko 2020-11-10 7114 fib_event);
c1b290d594a12b Jiri Pirko 2020-11-10 7115 break;
c1b290d594a12b Jiri Pirko 2020-11-10 7116 case AF_INET6:
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7117 mlxsw_sp_router_fib6_event_process(mlxsw_sp, op_ctx,
2d5bd7a111ca08 Jiri Pirko 2020-11-10 7118 fib_event);
c1b290d594a12b Jiri Pirko 2020-11-10 7119 break;
c1b290d594a12b Jiri Pirko 2020-11-10 7120 case RTNL_FAMILY_IP6MR:
c1b290d594a12b Jiri Pirko 2020-11-10 7121 case RTNL_FAMILY_IPMR:
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7122 /* Unlock here as inside FIBMR the lock is taken again
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7123 * under RTNL. The per-instance operation context
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7124 * is not used by FIBMR.
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7125 */
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7126 mutex_unlock(&router->lock);
c1b290d594a12b Jiri Pirko 2020-11-10 7127 mlxsw_sp_router_fibmr_event_process(mlxsw_sp,
c1b290d594a12b Jiri Pirko 2020-11-10 7128 fib_event);
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7129 mutex_lock(&router->lock);
c1b290d594a12b Jiri Pirko 2020-11-10 7130 break;
c1b290d594a12b Jiri Pirko 2020-11-10 7131 default:
c1b290d594a12b Jiri Pirko 2020-11-10 7132 WARN_ON_ONCE(1);
c1b290d594a12b Jiri Pirko 2020-11-10 7133 }
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7134 last_family = fib_event->family;
c1b290d594a12b Jiri Pirko 2020-11-10 7135 kfree(fib_event);
c1b290d594a12b Jiri Pirko 2020-11-10 7136 cond_resched();
c1b290d594a12b Jiri Pirko 2020-11-10 7137 }
ae9ce81aa726ef Jiri Pirko 2020-11-10 7138 WARN_ON_ONCE(!list_empty(&router->ll_op_ctx->fib_entry_priv_list));
91d20d71b2f0b1 Jiri Pirko 2020-11-10 7139 mutex_unlock(&router->lock);
c1b290d594a12b Jiri Pirko 2020-11-10 7140 }
c1b290d594a12b Jiri Pirko 2020-11-10 7141
:::::: The code at line 7071 was first introduced by commit
:::::: c1b290d594a12b4ed3b7386947162d5a061900b2 mlxsw: spectrum_router: Introduce FIB event queue instead of separate works
:::::: TO: Jiri Pirko <jiri@...dia.com>
:::::: CC: Jakub Kicinski <kuba@...nel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (34446 bytes)
Powered by blists - more mailing lists