linux-kernel - Re: [PATCH] NFC: nxp-nci: remove unnecessary labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6129efc3-fe4f-8b09-22cd-3d17354e1c7a@canonical.com>
Date:   Tue, 15 Jun 2021 09:17:36 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     samirweng1979 <samirweng1979@....com>, charles.gorand@...innov.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        wengjianfeng <wengjianfeng@...ong.com>
Subject: Re: [PATCH] NFC: nxp-nci: remove unnecessary labels

On 15/06/2021 03:52, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@...ong.com>
> 
> Some labels are meaningless, so we delete them and use the
> return statement instead of the goto statement.
> 
> Signed-off-by: wengjianfeng <wengjianfeng@...ong.com>
> ---
>  drivers/nfc/nxp-nci/core.c | 39 +++++++++++++--------------------------
>  1 file changed, 13 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/nfc/nxp-nci/core.c b/drivers/nfc/nxp-nci/core.c
> index a0ce95a..2b0c723 100644
> --- a/drivers/nfc/nxp-nci/core.c
> +++ b/drivers/nfc/nxp-nci/core.c
> @@ -70,21 +70,16 @@ static int nxp_nci_send(struct nci_dev *ndev, struct sk_buff *skb)
>  	struct nxp_nci_info *info = nci_get_drvdata(ndev);
>  	int r;
>  
> -	if (!info->phy_ops->write) {
> -		r = -ENOTSUPP;
> -		goto send_exit;
> -	}
> +	if (!info->phy_ops->write)
> +		return -EOPNOTSUPP;

You changed ENOTSUPP into EOPNOTSUPP, which unrelated to the patch. Make
it a separate patch with its own explanation.


Best regards,
Krzysztof