linux-kernel - Re: [PATCH] usb: renesas-xhci: Fix handling of unknown ROM state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMhcV39CtSx0F45o@vkoul-mobl>
Date:   Tue, 15 Jun 2021 13:22:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Moritz Fischer <mdf@...nel.org>, maz@...nel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Mathias Nyman <mathias.nyman@...el.com>
Subject: Re: [PATCH] usb: renesas-xhci: Fix handling of unknown ROM state

On 15-06-21, 09:15, Greg KH wrote:
> On Mon, Jun 14, 2021 at 07:25:14PM -0700, Moritz Fischer wrote:
> > If the ROM status returned is unknown (RENESAS_ROM_STATUS_NO_RESULT)
> > we need to attempt loading the firmware rather than just skipping
> > it all together.
> 
> How can this happen?  Can you provide more information here?

Sometimes ROM load seems to return unknown status, this helps in those
cases by doing attempting RAM load. The status should be success of
fail, here it is neither :(

I have tested this on 96 boards RB3 on a loaded ROM device as well as
ROM erased one. Works good and is improvement in the cases where ROM
status is 'unknown'


Tested-by: Vinod Koul <vkoul@...nel.org>
Reviewed-by: Vinod Koul <vkoul@...nel.org>

-- 
~Vinod