linux-kernel - RE: [PATCH 2/9] habanalabs: zero complex structures using memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ad1aa7cc1504b759f997028c80a6bd6@AcuMS.aculab.com>
Date:   Tue, 15 Jun 2021 08:27:38 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Oded Gabbay' <ogabbay@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Koby Elbaz <kelbaz@...ana.ai>
Subject: RE: [PATCH 2/9] habanalabs: zero complex structures using memset

From: Oded Gabbay
> Sent: 14 June 2021 13:51
> 
> From: Koby Elbaz <kelbaz@...ana.ai>
> 
> fix the following sparse warnings:
> 'warning: Using plain integer as NULL pointer'
> 'warning: missing braces around initializer'

Sparse is being over-enthusiastic.

...
> diff --git a/drivers/misc/habanalabs/common/firmware_if.c
> b/drivers/misc/habanalabs/common/firmware_if.c
> index 14e70422af25..d5d0db7fd6ef 100644
> --- a/drivers/misc/habanalabs/common/firmware_if.c
> +++ b/drivers/misc/habanalabs/common/firmware_if.c
> @@ -392,10 +392,11 @@ void hl_fw_cpu_accessible_dma_pool_free(struct hl_device *hdev, size_t size,
> 
>  int hl_fw_send_heartbeat(struct hl_device *hdev)
>  {
> -	struct cpucp_packet hb_pkt = {0};
> +	struct cpucp_packet hb_pkt;

Try just deleting the 0?
I think modern compilers allow {}.

	David

>  	u64 result;
>  	int rc;
> 
> +	memset(&hb_pkt, 0, sizeof(hb_pkt));
>  	hb_pkt.ctl = cpu_to_le32(CPUCP_PACKET_TEST <<
>  					CPUCP_PKT_CTL_OPCODE_SHIFT);
>  	hb_pkt.value = cpu_to_le64(CPUCP_PACKET_FENCE_VAL);
> --
> 2.25.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)