linux-kernel - Re: [PATCH] quota: finish disable quotactl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210615091635.moujr4zgfy3gqc6j@wittgenstein>
Date:   Tue, 15 Jun 2021 11:16:35 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Jan Kara <jack@...e.cz>
Cc:     Marcin Juszkiewicz <marcin@...zkiewicz.com.pl>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH] quota: finish disable quotactl_path syscall

On Tue, Jun 15, 2021 at 10:47:28AM +0200, Jan Kara wrote:
> On Mon 14-06-21 18:44:54, Jan Kara wrote:
> > On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > > disabled quotactl_path syscall on several architectures.
> > > 
> > > This commit disables it on all architectures using unified list of
> > > system calls:
> > > 
> > > - arm64
> > > - arc
> > > - csky
> > > - h8300
> > > - hexagon
> > > - nds32
> > > - nios2
> > > - openrisc
> > > - riscv (32/64)
> > > 
> > > CC: Jan Kara <jack@...e.cz>
> > > CC: Christian Brauner <christian.brauner@...ntu.com>
> > > CC: Sascha Hauer <s.hauer@...gutronix.de>
> > > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > > 
> > > Signed-off-by: Marcin Juszkiewicz <marcin@...zkiewicz.com.pl>
> > 
> > Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> > this patch or should I take it through my tree?
> 
> OK, I want this to make it for rc7 so I've pulled this patch to my tree and
> will push it to Linus in a few days.

Looks good, thanks!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>

> 
> 								Honza
> 
> > > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> > > index 6de5a7fc066b..d2a942086fcb 100644
> > > --- a/include/uapi/asm-generic/unistd.h
> > > +++ b/include/uapi/asm-generic/unistd.h
> > > @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> > >  __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> > >  #define __NR_mount_setattr 442
> > >  __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> > > -#define __NR_quotactl_path 443
> > > -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> > > +/* 443 is reserved for quotactl_path */
> > >  
> > >  #define __NR_landlock_create_ruleset 444
> > >  __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> > > -- 
> > > 2.31.1
> > > 
> > -- 
> > Jan Kara <jack@...e.com>
> > SUSE Labs, CR
> -- 
> Jan Kara <jack@...e.com>
> SUSE Labs, CR