linux-kernel - Re: [PATCH v2 -next] drm/hyperv: Fix unused const variable 'hyperv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 11:25:27 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Pu Lehui <pulehui@...wei.com>, drawat.floss@...il.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     zhangjinhao2@...wei.com, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 -next] drm/hyperv: Fix unused const variable
 'hyperv_modifiers'

Hi

Am 15.06.21 um 05:14 schrieb Pu Lehui:
> There is a gcc '-Wunused-const-variable' warning:
>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
>      'hyperv_modifiers' defined but not used [-Wunused-const-variable=]
> 
> while the variable should be used in drm_simple_display_pipe_init()
> as suggested by Thomas, let's fix it.

Thanks a lot! I added your patch to drm-misc-next-fixes.

Best regards
Thomas

> 
> Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
> Signed-off-by: Pu Lehui <pulehui@...wei.com>
> ---
>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 02718e3e859e..3aaee4730ec6 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -163,7 +163,7 @@ static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
>   					   &hyperv_pipe_funcs,
>   					   hyperv_formats,
>   					   ARRAY_SIZE(hyperv_formats),
> -					   NULL,
> +					   hyperv_modifiers,
>   					   &hv->connector);
>   	if (ret)
>   		return ret;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)