linux-kernel - Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 10:48:28 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Yanan Wang <wangyanan55@...wei.com>
Cc:     James Morse <james.morse@....com>,
        Alexandru Elisei <alexandru.elisei@....com>,
        Eric Auger <eric.auger@...hat.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <kvmarm@...ts.cs.columbia.edu>, <linux-kernel@...r.kernel.org>,
        <yuzenghui@...wei.com>, <wanghaibin.wang@...wei.com>
Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files

On Tue, 15 Jun 2021 04:50:19 +0100,
Yanan Wang <wangyanan55@...wei.com> wrote:
> 
> These fixes introduce no functional change but just adjustment about
> coding style issues for ARM64 vgic code. They mainly include identation
> fix of function parameters/arguments, identation fix of structure
> initialization, identation fix of comment, also the deletion of some
> superfluous space lines.

Please don't. This sort of patches bring little value, and make the
backporting of important fixes more difficult because of pointless
context change.

Fixing these cosmetic details is fine when you are modifying the
code. But as a standalone patch, this brings more pain than benefit.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.