linux-kernel - Re: [PATCH -next] drm/hyperv: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5944abf7-7535-f425-fdc3-58e6bd032186@huawei.com>
Date:   Tue, 15 Jun 2021 10:10:55 +0800
From:   Pu Lehui <pulehui@...wei.com>
To:     Deepak Rawat <drawat.floss@...il.com>,
        Thomas Zimmermann <tzimmermann@...e.de>, <airlied@...ux.ie>,
        <daniel@...ll.ch>
CC:     <zhangjinhao2@...wei.com>, <linux-hyperv@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH -next] drm/hyperv: Remove unused variable



On 2021/6/14 22:01, Deepak Rawat wrote:
> On Wed, 2021-06-09 at 09:46 +0200, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 09.06.21 um 04:49 schrieb Pu Lehui:
>>> Fixes gcc '-Wunused-const-variable' warning:
>>>     drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
>>>       'hyperv_modifiers' defined but not used [-Wunused-const-
>>> variable=]
>>>
>>> Signed-off-by: Pu Lehui <pulehui@...wei.com>
>>> ---
>>>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>>> b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>>> index 02718e3e859e..3f83493909e6 100644
>>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>>> @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
>>>          DRM_FORMAT_XRGB8888,
>>>    };
>>>    
>>> -static const uint64_t hyperv_modifiers[] = {
>>> -       DRM_FORMAT_MOD_LINEAR,
>>> -       DRM_FORMAT_MOD_INVALID
>>> -};
>>
>> This constant should rather be used in the call to
>> drm_simple_display_pipe_init(). [1]
>>
>> Best regards
>> Thomas
>>
>> [1]
>> https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161
>>
>>
> 
> Hi Pu,
> 
> Thanks for the patch. Is it possible to send another patch as per
> suggestion by Thomas. There is a kernel test robot failure as well.
> 
> Deepak
> 
> .
> 
Hi Deepak,

Thanks for your reply, I will send v2 soon.

Best regards
Lehui