linux-kernel - Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210615115438.GD5149@sirena.org.uk>
Date:   Tue, 15 Jun 2021 12:54:38 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Claudius Heine <ch@...x.de>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        Marek Vasut <marex@...x.de>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Sia Jee Heng <jee.heng.sia@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Annaliese McDermond <nh6z@...z.net>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different
 device variants

On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote:

> With this change it will be possible to add different code paths for
> similar devices.

>  static const struct i2c_device_id aic32x4_i2c_id[] = {
> -	{ "tlv320aic32x4", 0 },
> -	{ "tlv320aic32x6", 1 },
> +	{ "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 },
> +	{ "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 },
>  	{ /* sentinel */ }

It appears that the device already supports multiple variants?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)