linux-kernel - [PATCH] afs: fix no return statement in function returning non-void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <162375813191.653958.11993495571264748407.stgit@warthog.procyon.org.uk>
Date:   Tue, 15 Jun 2021 12:55:31 +0100
From:   David Howells <dhowells@...hat.com>
To:     torvalds@...ux-foundation.org
Cc:     Hulk Robot <hulkci@...wei.com>,
        Zheng Zengkai <zhengzengkai@...wei.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Tom Rix <trix@...hat.com>, linux-afs@...ts.infradead.org,
        dhowells@...hat.com, marc.dionne@...istor.com,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] afs: fix no return statement in function returning non-void

From: Zheng Zengkai <zhengzengkai@...wei.com>

Add missing return to fix following compilation issue:

fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’:
fs/afs/dir.c:51:1: error: no return statement in function
returning non-void [-Werror=return-type]

Fixes: f3ddee8dc4e2 ("afs: Fix directory handling")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@...wei.com>
Acked-by: Randy Dunlap <rdunlap@...radead.org>
cc: Tom Rix <trix@...hat.com>
cc: linux-afs@...ts.infradead.org
Link: https://lore.kernel.org/r/20210327121624.194639-1-zhengzengkai@huawei.com/
---

 fs/afs/dir.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 78719f2f567e..c31c21afd2e1 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset,
 static int afs_dir_set_page_dirty(struct page *page)
 {
 	BUG(); /* This should never happen. */
+	return 0;
 }
 
 const struct file_operations afs_dir_file_operations = {