linux-kernel - Re: [PATCH -next] drm/nouveau: Remove set but not used variable 'width'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 09:58:06 +0800
From:   "libaokun (A)" <libaokun1@...wei.com>
To:     <bskeggs@...hat.com>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <nouveau@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>
CC:     <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>,
        <yangjihong1@...wei.com>, <yukuai3@...wei.com>
Subject: Re: [PATCH -next] drm/nouveau: Remove set but not used variable
 'width'

ping

在 2021/5/25 16:17, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
> drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
>   variable ‘width’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 929de41c281f..2b460835a438 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
>   	struct drm_framebuffer *fb;
>   	const struct drm_format_info *info;
> -	unsigned int width, height, i;
> +	unsigned int height, i;
>   	uint32_t tile_mode;
>   	uint8_t kind;
>   	int ret;
> @@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	info = drm_get_format_info(dev, mode_cmd);
>   
>   	for (i = 0; i < info->num_planes; i++) {
> -		width = drm_format_info_plane_width(info,
> -						    mode_cmd->width,
> -						    i);
>   		height = drm_format_info_plane_height(info,
>   						      mode_cmd->height,
>   						      i);