linux-kernel - Re: [PATCH 0/8] staging: rtl8723bs: remove unneeded files from tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8109abbd-f7ae-2b88-4b99-98151322c843@redhat.com>
Date:   Tue, 15 Jun 2021 14:11:26 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] staging: rtl8723bs: remove unneeded files from tree

Hi,

On 6/15/21 1:45 PM, Fabio Aiuto wrote:
> This patchset removes some unneeded files.
> 
> autoconf.h seems to be the output of some automatic
> header file generation foreign to the linux kernel
> configuration and build system.
> 
> To toggle some part of code one is asked to
> force an edit by hand on this file.
> 
> Other unneeded definitions were deleted recently,
> now we complete the job.
> 
> Removed core/rtw_eeprom.c and include/drv_conf.h as well,
> for they are excluded from the build process.
> 
> Tested-by: Fabio Aiuto <fabioaiuto83@...il.com>

Thank you, series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

for the series,

Regards,

Hans

> 
> Fabio Aiuto (8):
>   staging: rtl8723bs: remove unused debug macro
>   staging: rtl8723bs: remove unneeded comments
>   staging: rtl8723bs: remove unused WAKEUP_GPIO_IDX macro definition
>   staging: rtl8723bs: remove unneeded DISABLE_BB_RF macro
>   staging: rtl8723bs: remove HAL_{BB,MAC,RF,FW}_ENABLE macros
>   staging: rtl8723bs: move LPS_RPWM_WAIT_MS macro
>   staging: rtl8723bs: remove include/autoconf.h header file from tree
>   staging: rtl8723bs: remove two unused files from tree
> 
>  drivers/staging/rtl8723bs/core/rtw_eeprom.c   | 208 ------------------
>  .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    |   7 -
>  .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |  16 --
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  15 --
>  drivers/staging/rtl8723bs/include/autoconf.h  |  50 -----
>  drivers/staging/rtl8723bs/include/drv_conf.h  |  19 --
>  drivers/staging/rtl8723bs/include/drv_types.h |   1 -
>  .../staging/rtl8723bs/include/hal_btcoex.h    |   2 +
>  drivers/staging/rtl8723bs/include/hal_phy.h   |  14 --
>  .../staging/rtl8723bs/include/rtl8723b_spec.h |   2 -
>  10 files changed, 2 insertions(+), 332 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/core/rtw_eeprom.c
>  delete mode 100644 drivers/staging/rtl8723bs/include/autoconf.h
>  delete mode 100644 drivers/staging/rtl8723bs/include/drv_conf.h
>