linux-kernel - Re: [PATCH] mfd: max8907: Remove IRQF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMiawr+12Uq4Q2n+@dell>
Date:   Tue, 15 Jun 2021 13:19:14 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Sergey Larin <cerg2010cerg2010@...l.ru>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max8907: Remove IRQF_NO_AUTOEN flag

On Tue, 15 Jun 2021, Sergey Larin wrote:

> IRQF_NO_AUTOEN flag doesn't go well with IRQF_SHARED flag - the
> check in request_threaded_irq fails and exits with EINVAL.
> 
> So we ignore the flag and enable it on the first IRQ request. No
> interrupt should arrive from the chip as all interrupts are masked
> by default.
> 
> Signed-off-by: Sergey Larin <cerg2010cerg2010@...l.ru>
> ---
>  drivers/mfd/max8907.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog