linux-kernel - Re: [PATCH -next] video: fbdev: intelfb: Remove set but not used variable 'val'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 09:58:35 +0800
From:   "libaokun (A)" <libaokun1@...wei.com>
To:     <mbroemme@...mpq.org>, <linux-fbdev@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
CC:     <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>,
        <yangjihong1@...wei.com>, <yukuai3@...wei.com>
Subject: Re: [PATCH -next] video: fbdev: intelfb: Remove set but not used
 variable 'val'

ping

在 2021/5/27 16:59, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setscl':
> drivers/video/fbdev/intelfb/intelfb_i2c.c:58:6: warning:
>   variable ‘val’ set but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/intelfb/intelfb_i2c.c: In function 'intelfb_gpio_setsda':
> drivers/video/fbdev/intelfb/intelfb_i2c.c:69:6: warning:
>   variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
>   drivers/video/fbdev/intelfb/intelfb_i2c.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c
> index 3300bd31d9d7..4df2f1f8a18e 100644
> --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c
> +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c
> @@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state)
>   {
>   	struct intelfb_i2c_chan *chan = data;
>   	struct intelfb_info *dinfo = chan->dinfo;
> -	u32 val;
>   
>   	OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) |
>   	       SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK);
> -	val = INREG(chan->reg);
> +	INREG(chan->reg);
>   }
>   
>   static void intelfb_gpio_setsda(void *data, int state)
>   {
>   	struct intelfb_i2c_chan *chan = data;
>   	struct intelfb_info *dinfo = chan->dinfo;
> -	u32 val;
>   
>   	OUTREG(chan->reg, (state ? SDA_VAL_OUT : 0) |
>   	       SDA_DIR | SDA_DIR_MASK | SDA_VAL_MASK);
> -	val = INREG(chan->reg);
> +	INREG(chan->reg);
>   }
>   
>   static int intelfb_gpio_getscl(void *data)