linux-kernel - Re: [PATCH] ASoC: codecs: wcd938x: remove incorrect module interdependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210615123206.GA50640@sirena.org.uk>
Date:   Tue, 15 Jun 2021 13:35:11 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        lgirdwood@...il.com, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] ASoC: codecs: wcd938x: remove incorrect module
 interdependency

On Tue, Jun 15, 2021 at 10:48:39AM +0100, Srinivas Kandagatla wrote:
> For some reason we ended up with cyclic dependency between snd_soc_wcd938x
> and snd_soc_wcd938x_sdw modules.
> 
> Remove this cyclic dependency by handling them in respective modules.
> Without this below error is reported during make modules_install

This breaks an x86 allmodconfig build:

/mnt/kernel/sound/soc/codecs/wcd938x-sdw.c: In function 'wcd9380_interrupt_callback':
/mnt/kernel/sound/soc/codecs/wcd938x-sdw.c:184:3: error: implicit declaration of function 'handle_nested_irq' [-Werror=implicit-function-declaration]
   handle_nested_irq(irq_find_mapping(slave_irq, 0));
   ^~~~~~~~~~~~~~~~~


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)