linux-kernel - Re: [PATCH][next][V2] net: pcs: xpcs: Fix a less than zero u16 comparison error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210615140106.4qqygvptmx4yctwb@skbuf>
Date:   Tue, 15 Jun 2021 17:01:06 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next][V2] net: pcs: xpcs: Fix a less than zero u16
 comparison error

On Tue, Jun 15, 2021 at 02:52:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the check for the u16 variable val being less than zero is
> always false because val is unsigned. Fix this by using the int
> variable for the assignment and less than zero check.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: f7380bba42fd ("net: pcs: xpcs: add support for NXP SJA1110")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> V2: Fix typo in subject and align the following 2 lines after the 
>     val = ret & ... assignment.  Thanks to Vladimir Oltean for spotting
>     these.
> ---

Thanks.

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>