linux-kernel - Re: [PATCH 7/8] all: replace find_next{,_zero}_bit with find_first{,_zero}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210614180706.1e8564854bfed648dd4c039b@linux-foundation.org>
Date:   Mon, 14 Jun 2021 18:07:06 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Yury Norov <yury.norov@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Yoshinori Sato <ysato@...rs.osdn.me>,
        Brian Cain <bcain@...eaurora.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Rich Felker <dalias@...c.org>,
        David Hildenbrand <david@...hat.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Alexander Lobakin <alobakin@...me>,
        Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Alexey Klimov <aklimov@...hat.com>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 7/8] all: replace find_next{,_zero}_bit with
 find_first{,_zero}_bit where appropriate

On Sun, 13 Jun 2021 12:41:38 +0300 Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Sunday, June 13, 2021, Yury Norov <yury.norov@...il.com> wrote:
> 
> > On Sun, Jun 13, 2021 at 12:47:31AM +0300, Andy Shevchenko wrote:
> > > On Sat, Jun 12, 2021 at 3:39 PM Yury Norov <yury.norov@...il.com> wrote:
> > > >
> > > > find_first{,_zero}_bit is a more effective analogue of 'next' version
> > if
> > > > start == 0. This patch replaces 'next' with 'first' where things look
> > > > trivial.
> > >
> > > Depending on the maintainers (but I think there will be at least few
> > > in this case) they would like to have this be split on a per-driver
> > > basis.
> > > I counted 17 patches. I would split.
> > >
> > > Since many of them are independent you may send without Cc'ing all
> > > non-relevant people in each case.
> >
> > submitting-patches.rst says:
> >
> >         On the other hand, if you make a single change to numerous files,
> >         group those changes into a single patch.  Thus a single logical
> > change
> >         is contained within a single patch.
> >
> > Also refer 96d4f267e40f9 ("Remove 'type' argument from access_ok()
> > functioin.")
> 
> 
> Mixing arch and non arch is not good, fs stuff can be separated as well,
> so, at least 4 patches. Otherwise it might be not good for bissection /
> reverting.

Actually I don't have a problem taking/merging splatterpatches like
this one, as long as all relevant maintainers are cc'ed throughout. 

If they review/test/ack then great.  If they don't then their stuff
breaks during -rc and they get to fix it (this almost never happens
anyway).

If the splatterpatch is prepared as a series of patches then that's OK
as well.  I'll queue them all up behind linux-next so I can see when
maintainers have merged them and drop the individual patches as/when
needed.

On balance...  I guess individual patches is a bit better because the
more diligent maintainers will sometimes merge them and get them better
tested.  But in practice, 95% of maintainers will eyeball it, say "yeah
fine" and let Andrew handle it.