[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <929460.1623850895@warthog.procyon.org.uk>
Date: Wed, 16 Jun 2021 14:41:35 +0100
From: David Howells <dhowells@...hat.com>
To: Tom Rix <trix@...hat.com>
Cc: dhowells@...hat.com, Zheng Zengkai <zhengzengkai@...wei.com>,
Randy Dunlap <rdunlap@...radead.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Hulk Robot <hulkci@...wei.com>, linux-afs@...ts.infradead.org,
Marc Dionne <marc.dionne@...istor.com>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void
Tom Rix <trix@...hat.com> wrote:
> A fix is to use the __noreturn attribute on this function and not add a return
> like this
>
> -static int afs_dir_set_page_dirty(struct page *page)
> +static int __noreturn afs_dir_set_page_dirty(struct page *page)
>
> and to the set of ~300 similar functions in these files.
BUG() really ought to handle it. Do you have CONFIG_BUG=y?
David
Powered by blists - more mailing lists