linux-kernel - Re: [PATCH -next] scsi: mpi3mr: Fix missing unlock on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHsXFKGkRDdqc5kNozCrw=7CgORAp0_jyt+-7FW=n62r2xmvFA@mail.gmail.com>
Date:   Wed, 16 Jun 2021 19:16:24 +0530
From:   Kashyap Desai <kashyap.desai@...adcom.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH -next] scsi: mpi3mr: Fix missing unlock on error

> Goto unlock path before return from function
> in the error handling case.
>
> Fixes: c9566231cfaf ("scsi: mpi3mr: Create operational request and reply queue pair")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/scsi/mpi3mr/mpi3mr_fw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> index dbf116414855..8aea1c2ae712 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> @@ -1583,7 +1583,7 @@ static int mpi3mr_create_op_reply_q(struct mpi3mr_ioc *mrioc, u16 qidx)
>         if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
>                 retval = -1;
>                 ioc_err(mrioc, "CreateRepQ: Init command is in use\n");
> -               goto out;
> +               goto out_unlock;
>         }
>         mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
>         mrioc->init_cmds.is_waiting = 1;
> @@ -1692,7 +1692,7 @@ static int mpi3mr_create_op_req_q(struct mpi3mr_ioc *mrioc, u16 idx,
>         if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
>                 retval = -1;
>                 ioc_err(mrioc, "CreateReqQ: Init command is in use\n");
> -               goto out;
> +               goto out_unlock;
>         }
>         mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
>         mrioc->init_cmds.is_waiting = 1;

Acked-by: Kashyap Desai <kashyap.desai@...adcom.com>
> --
> 2.25.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)