linux-kernel - [PATCH] locking/lockdep: print possible warning after counting deps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210616144210.278662-2-sxwjean@me.com>
Date:   Wed, 16 Jun 2021 22:42:10 +0800
From:   Xiongwei Song <sxwjean@...com>
To:     peterz@...radead.org, mingo@...hat.com, will@...nel.org,
        longman@...hat.com, boqun.feng@...il.com
Cc:     linux-kernel@...r.kernel.org, Xiongwei Song <sxwjean@...il.com>
Subject: [PATCH] locking/lockdep: print possible warning after counting deps

From: Xiongwei Song <sxwjean@...il.com>

The graph walk might hit error when counting dependencies. Once the
return value is negative, print a warning to reminder users.

Signed-off-by: Xiongwei Song <sxwjean@...il.com>
---
 kernel/locking/lockdep.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 7641bd407239..074fd6418c20 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -2028,8 +2028,12 @@ static unsigned long __lockdep_count_forward_deps(struct lock_list *this)
 {
 	unsigned long  count = 0;
 	struct lock_list *target_entry;
+	enum bfs_result ret;
+
+	ret = __bfs_forwards(this, (void *)&count, noop_count, NULL, &target_entry);
 
-	__bfs_forwards(this, (void *)&count, noop_count, NULL, &target_entry);
+	if (unlikely(bfs_error(ret)))
+		print_bfs_bug(ret);
 
 	return count;
 }
@@ -2053,8 +2057,12 @@ static unsigned long __lockdep_count_backward_deps(struct lock_list *this)
 {
 	unsigned long  count = 0;
 	struct lock_list *target_entry;
+	enum bfs_result ret;
+
+	ret = __bfs_backwards(this, (void *)&count, noop_count, NULL, &target_entry);
 
-	__bfs_backwards(this, (void *)&count, noop_count, NULL, &target_entry);
+	if (unlikely(bfs_error(ret)))
+		print_bfs_bug(ret);
 
 	return count;
 }
-- 
2.30.2