linux-kernel - Re: [PATCH] regulator: rt6160: Fix setting suspend voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1623809182.3584.5.camel@richtek.com>
Date:   Wed, 16 Jun 2021 02:06:22 +0000
From:   cy_huang(黃啟原) <cy_huang@...htek.com>
To:     "axel.lin@...ics.com" <axel.lin@...ics.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "u0084500@...il.com" <u0084500@...il.com>
Subject: Re: [PATCH] regulator: rt6160: Fix setting suspend voltage

> The vsel active level is for the normal voltage, the opposite level is
> the suspend voltage.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> Hi ChiYuan,
> I think fix it this way make the intention more clear.
>
>  drivers/regulator/rt6160-regulator.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
Thx. It's more intuitive.

Reviewed-by: ChiYuan Huang <cy_huang@...htek.com>

> diff --git a/drivers/regulator/rt6160-regulator.c b/drivers/regulator/rt6160-
> regulator.c
> index ccd023da4318..5d7b0e7ad69a 100644
> --- a/drivers/regulator/rt6160-regulator.c
> +++ b/drivers/regulator/rt6160-regulator.c
> @@ -128,13 +128,19 @@ static unsigned int rt6160_get_mode(struct regulator_dev
> *rdev)
>  static int rt6160_set_suspend_voltage(struct regulator_dev *rdev, int uV)
>  {
>  struct regmap *regmap = rdev_get_regmap(rdev);
> +unsigned int suspend_vsel_reg;
>  int vsel;
>
>  vsel = regulator_map_voltage_linear(rdev, uV, uV);
>  if (vsel < 0)
>  return vsel;
>
> -return regmap_update_bits(regmap, rdev->desc->vsel_reg,
> +if (rdev->desc->vsel_reg == RT6160_REG_VSELL)
> +suspend_vsel_reg = RT6160_REG_VSELH;
> +else
> +suspend_vsel_reg = RT6160_REG_VSELL;
> +
> +return regmap_update_bits(regmap, suspend_vsel_reg,
>    RT6160_VSEL_MASK, vsel);
>  }
>
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!