linux-kernel - Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMoap5Vi6ZkXgKr3@shredder>
Date:   Wed, 16 Jun 2021 18:37:11 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Cc:     jiri@...dia.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vadym Kochan <vadym.kochan@...ision.eu>, andrew@...n.ch,
        nikolay@...dia.com
Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink
 trap_drop_counter_get implementation

On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote:
> +	debugfs_create_bool("fail_trap_counter_get", 0600,

The test is doing:

echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get

And fails with:

./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied

Please fix netdevsim to instantiate the correct file and avoid
submitting new tests without running them first.


> +			    nsim_dev->ddir,
> +			    &nsim_dev->fail_trap_counter_get);
>  	nsim_udp_tunnels_debugfs_create(nsim_dev);
>  	return 0;