linux-kernel - Re: [patch V2 14/52] x86/fpu: Make copy_xstate_to_kernel() usable for [x]fpregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMojMrxr+UwI0cVR@zn.tnic>
Date:   Wed, 16 Jun 2021 18:13:38 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [patch V2 14/52] x86/fpu: Make copy_xstate_to_kernel() usable
 for [x]fpregs_get()

On Mon, Jun 14, 2021 at 05:44:22PM +0200, Thomas Gleixner wrote:
> When xsave with init state optimiziation is used then a component's state

				optimization

> @@ -1062,14 +1062,20 @@ static void copy_feature(bool from_xstat
>  	membuf_write(to, from_xstate ? xstate : init_xstate, size);
>  }
>  
> -/*
> - * Convert from kernel XSAVE or XSAVES compacted format to UABI
> - * non-compacted format and copy to a kernel-space ptrace buffer.
> +/**
> + * copy_uabi_xstate_to_membuf - Copy kernel saved xstate to a UABI buffer

If this is what it does, then the function should be called:

copy_xstate_to_uabi_buf()

or so.

"membuf" is only an implementation detail anyway. IMHO.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg