linux-kernel - Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMoktwkvCP8yGyhk@lunn.ch>
Date:   Wed, 16 Jun 2021 18:20:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Guangbin Huang <huangguangbin2@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, xie.he.0141@...il.com,
        ms@....tdt.de, willemb@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lipeng321@...wei.com
Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

>  static int cp_table[EVENTS][STATES] = {
>  	/* CLOSED     STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
> -	     0           1         2       3       4      5          6    */
> +	 *   0           1         2       3       4      5          6
> +	 */
>  	{IRC|SCR|3,     INV     , INV ,   INV   , INV ,  INV    ,   INV   }, /* START */
>  	{   INV   ,      0      ,  0  ,    0    ,  0  ,   0     ,    0    }, /* STOP */
>  	{   INV   ,     INV     ,STR|2,  SCR|3  ,SCR|3,  SCR|5  ,   INV   }, /* TO+ */

This probably reduces the readability of the code. So i would not make
this change.

Please remember these are only guidelines. Please don't blindly make
changes, or change it because some bot says so. Check that it actually
makes sense and the code is better afterwards.

      Andrew