linux-kernel - Re: [PATCH v2 2/2] dt-bindings: clock: ad9545: Add documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202106170216.VGvLSXtj-lkp@intel.com>
Date:   Thu, 17 Jun 2021 02:53:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     alexandru.tachici@...log.com, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, robh+dt@...nel.org, sboyd@...nel.org,
        mturquette@...libre.com, petre.minciunescu@...log.com,
        Alexandru Tachici <alexandru.tachici@...log.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: clock: ad9545: Add documentation

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next linux/master linus/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/alexandru-tachici-analog-com/clk-ad9545-Add-support/20210616-153412
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b46755cf562ff8a1a9841a4560e344099f3f054e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review alexandru-tachici-analog-com/clk-ad9545-Add-support/20210616-153412
        git checkout b46755cf562ff8a1a9841a4560e344099f3f054e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/clk/adi/clk-ad9545.c:2402:5: warning: no previous prototype for 'ad9545_probe' [-Wmissing-prototypes]
    2402 | int ad9545_probe(struct device *dev, struct regmap *regmap)
         |     ^~~~~~~~~~~~


vim +/ad9545_probe +2402 drivers/clk/adi/clk-ad9545.c

f88d17c990b731 Alexandru Tachici 2021-06-14  2401  
f88d17c990b731 Alexandru Tachici 2021-06-14 @2402  int ad9545_probe(struct device *dev, struct regmap *regmap)
f88d17c990b731 Alexandru Tachici 2021-06-14  2403  {
f88d17c990b731 Alexandru Tachici 2021-06-14  2404  	struct ad9545_state *st;
f88d17c990b731 Alexandru Tachici 2021-06-14  2405  	int ret;
f88d17c990b731 Alexandru Tachici 2021-06-14  2406  
f88d17c990b731 Alexandru Tachici 2021-06-14  2407  	st = devm_kzalloc(dev, sizeof(struct ad9545_state), GFP_KERNEL);
f88d17c990b731 Alexandru Tachici 2021-06-14  2408  	if (!st)
f88d17c990b731 Alexandru Tachici 2021-06-14  2409  		return -ENOMEM;
f88d17c990b731 Alexandru Tachici 2021-06-14  2410  
f88d17c990b731 Alexandru Tachici 2021-06-14  2411  	st->dev = dev;
f88d17c990b731 Alexandru Tachici 2021-06-14  2412  	st->regmap = regmap;
f88d17c990b731 Alexandru Tachici 2021-06-14  2413  
f88d17c990b731 Alexandru Tachici 2021-06-14  2414  	ret = ad9545_check_id(st);
f88d17c990b731 Alexandru Tachici 2021-06-14  2415  	if (ret < 0)
f88d17c990b731 Alexandru Tachici 2021-06-14  2416  		return ret;
f88d17c990b731 Alexandru Tachici 2021-06-14  2417  
f88d17c990b731 Alexandru Tachici 2021-06-14  2418  	ret = ad9545_parse_dt(st);
f88d17c990b731 Alexandru Tachici 2021-06-14  2419  	if (ret < 0)
f88d17c990b731 Alexandru Tachici 2021-06-14  2420  		return ret;
f88d17c990b731 Alexandru Tachici 2021-06-14  2421  
f88d17c990b731 Alexandru Tachici 2021-06-14  2422  	return ad9545_setup(st);
f88d17c990b731 Alexandru Tachici 2021-06-14  2423  }
f88d17c990b731 Alexandru Tachici 2021-06-14  2424  EXPORT_SYMBOL_GPL(ad9545_probe);
f88d17c990b731 Alexandru Tachici 2021-06-14  2425  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (59091 bytes)