linux-kernel - RE: [PATCH 1/3] scsi: storvsc: Miscellaneous code cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR21MB1593ABC5154A199022896D3ED70F9@MWHPR21MB1593.namprd21.prod.outlook.com>
Date:   Wed, 16 Jun 2021 19:54:29 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     KY Srinivasan <kys@...rosoft.com>, Long Li <longli@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH 1/3] scsi: storvsc: Miscellaneous code cleanups

From: Martin K. Petersen <martin.petersen@...cle.com> Sent: Tuesday, June 15, 2021 7:25 PM
> 
> Michael,
> 
> > As general cleanup and in preparation for subsequent patches:
> 
> Applied 1-3 to 5.14/scsi-staging.
> 
> Since Hannes' series has deprecated status_byte() and CHECK_CONDITION I
> had to tweak that portion. Please verify my conflict resolution.
> 

Unfortunately, it's not quite right.  The line of code in question needs to be

if ((vstor_packet->vm_srb.scsi_status & 0xFF) == SAM_STAT_CHECK_CONDITION &&

The status_byte() helper was doing the masking as well as the right shift, so the
masking will need to be open coded.  The replacement get_status_byte() helper 
won't work here because it's based on a scsi_cmnd structure.

Michael