linux-kernel - Re: [PATCH rdma-next] RDMA/mlx5: Don't add slave port to unaffiliated list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210616231940.GA1885358@nvidia.com>
Date:   Wed, 16 Jun 2021 20:19:40 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Daniel Jurgens <danielj@...lanox.com>,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        Parav Pandit <parav@...lanox.com>
Subject: Re: [PATCH rdma-next] RDMA/mlx5: Don't add slave port to
 unaffiliated list

On Mon, May 31, 2021 at 07:04:44PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> The mlx5_ib_bind_slave_port() doesn't remove multiport device from the
> unaffiliated list, but mlx5_ib_unbind_slave_port() did it. This unbalanced
> flow caused to the situation where mlx5_ib_unaffiliated_port_list was changed
> during iteration.
> 
> Fixes: 32f69e4be269 ("{net, IB}/mlx5: Manage port association for multiport RoCE")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason