linux-kernel - Re: [PATCH v3] block: fix trace completion for chained bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMmDxl9abff+wulm@infradead.org>
Date:   Wed, 16 Jun 2021 05:53:26 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     edwardh <edwardh@...ology.com>
Cc:     axboe@...nel.dk, neilb@...e.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, s3t@...ology.com,
        bingjingc@...ology.com, cccheng@...ology.com,
        Wade Liang <wadel@...ology.com>
Subject: Re: [PATCH v3] block: fix trace completion for chained bio

On Wed, Jun 16, 2021 at 11:08:10AM +0800, edwardh wrote:
> @@ -1400,18 +1404,13 @@ void bio_endio(struct bio *bio)
>  	if (bio->bi_end_io == bio_chain_endio) {
>  		bio = __bio_chain_endio(bio);
>  		goto again;
> +	} else {
> +		blk_throtl_bio_endio(bio);
> +		/* release cgroup info */
> +		bio_uninit(bio);
> +		if (bio->bi_end_io)
> +			bio->bi_end_io(bio);

No need for an else after a goto.