linux-kernel - Re: [PATCH V3] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <147a76286d85b3fc3e7b3060604b262b@codeaurora.org>
Date:   Wed, 16 Jun 2021 11:24:48 +0530
From:   sbhanu@...eaurora.org
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     adrian.hunter@...el.com, ulf.hansson@...aro.org,
        robh+dt@...nel.org, asutoshd@...eaurora.org,
        stummala@...eaurora.org, vbadigan@...eaurora.org,
        rampraka@...eaurora.org, sayalil@...eaurora.org,
        sartgarg@...eaurora.org, rnayak@...eaurora.org,
        saiprakash.ranjan@...eaurora.org, sibis@...eaurora.org,
        okukatla@...eaurora.org, djakov@...nel.org, cang@...eaurora.org,
        pragalla@...eaurora.org, nitirawa@...eaurora.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        agross@...nel.org
Subject: Re: [PATCH V3] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD
 card

On 2021-06-16 05:38, Bjorn Andersson wrote:
> On Tue 15 Jun 03:56 CDT 2021, sbhanu@...eaurora.org wrote:
> 
>> On 2021-06-14 17:00, sbhanu@...eaurora.org wrote:
>> > On 2021-06-11 09:12, Bjorn Andersson wrote:
>> > > On Wed 09 Jun 10:20 CDT 2021, Shaik Sajida Bhanu wrote:
> [..]
>> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> [..]
>> > > > +		sdhc_1: sdhci@...000 {
> [..]
>> > > > +			sdhc1_opp_table: sdhc1-opp-table {
>> > >
>> > > No need for "sdhc1-" in the node name.
>> > ok
>> Hi,
>> 
>> For Sd card also we have opp-table info so if we remove "sdhc1-" here 
>> and
>> "sdhc2-" in Sd crad opp table we may have dublicate nodes so,
>> it is better to keep sdhc1 and sdhc2 in node numbers right.
>> 
> 
> Are you saying that /soc/sdhci@...000/opp-table needs to have a unique
> name to not collide with /soc/sdhci@...4000/opp-table?
> 
> Regards,
> Bjorn

yes

Thanks,
Sajida