linux-kernel - Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jun 2021 08:56:01 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Punit Agrawal <punitagrawal@...il.com>, senozhatsky@...omium.org,
        rostedt@...dmis.org, john.ogness@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition

On Tue 2021-06-15 08:50:45, Rasmus Villemoes wrote:
> On 15/06/2021 01.56, Punit Agrawal wrote:
> > Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
> > improving readability by removing vprintk indirection, inadvertently
> > placed the EXPORT_SYMBOL() for the newly renamed function at the end
> > of the file.
> > 
> > For reader sanity, and as is convention move the EXPORT_SYMBOL()
> > declaration just after the end of the function.
> > 
> > Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
> > Signed-off-by: Punit Agrawal <punitagrawal@...il.com>
> > --
> > Hi,
> > 
> > The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
> > attempting to rebase the RT patches onto newer kernels.
> > 
> > Generally I avoid sending trivial changes on their own but this one is
> > a little hard to overlook. Also it felt like an obvious oversight in
> > the original patch.
> 
> Yes, indeed, sorry about that, and thanks for fixing it.

Yes, great catch.

> > Please consider merging.
> 
> Petr, as this is causing trouble for the -rt patchset, please consider
> if this could make it to Linus before v5.13 release.

Sure, I could do so. But could you please provide some more details
what exact problems it causes?

It looks like a cosmetic issue to me. It would be the only change
in the pull request. I would like to provide some reasonable
justification for it at this stage (for rc7).

Best Regards,
Petr