linux-kernel - Re: [PATCH v11 02/33] mm: Introduce struct folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <811608.1623835903@warthog.procyon.org.uk>
Date:   Wed, 16 Jun 2021 10:31:43 +0100
From:   David Howells <dhowells@...hat.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     dhowells@...hat.com, akpm@...ux-foundation.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Jeff Layton <jlayton@...nel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCH v11 02/33] mm: Introduce struct folio

Matthew Wilcox (Oracle) <willy@...radead.org> wrote:

> + * Return: The base-2 logarithm of the size of this folio.

You could probably just say "Return: log2 of the size of this folio".

Could we also get a synonym for page_offset()?  Perhaps called folio_fpos()
rather than folio_offset()?  "Offset" is a bit generic.

Reviewed-by: David Howells <dhowells@...hat.com>