linux-kernel - [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com>
Date:   Wed, 16 Jun 2021 17:33:54 +0800
From:   Guangbin Huang <huangguangbin2@...wei.com>
To:     <davem@...emloft.net>, <kuba@...nel.org>, <xie.he.0141@...il.com>,
        <ms@....tdt.de>, <willemb@...gle.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <huangguangbin2@...wei.com>
Subject: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

From: Peng Li <lipeng321@...wei.com>

Networking block comments don't use an empty /* line,
use /* Comment...

Block comments use * on subsequent lines.
Block comments use a trailing */ on a separate line.

This patch fixes the comments style issues.

Signed-off-by: Peng Li <lipeng321@...wei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
---
 drivers/net/wan/hdlc_ppp.c | 43 +++++++++++++++++++++----------------------
 1 file changed, 21 insertions(+), 22 deletions(-)

diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index fb5102c..9bda2c5 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -257,27 +257,25 @@ static void ppp_tx_cp(struct net_device *dev, u16 pid, u8 code,
 }
 
 /* State transition table (compare STD-51)
-   Events                                   Actions
-   TO+  = Timeout with counter > 0          irc = Initialize-Restart-Count
-   TO-  = Timeout with counter expired      zrc = Zero-Restart-Count
-
-   RCR+ = Receive-Configure-Request (Good)  scr = Send-Configure-Request
-   RCR- = Receive-Configure-Request (Bad)
-   RCA  = Receive-Configure-Ack             sca = Send-Configure-Ack
-   RCN  = Receive-Configure-Nak/Rej         scn = Send-Configure-Nak/Rej
-
-   RTR  = Receive-Terminate-Request         str = Send-Terminate-Request
-   RTA  = Receive-Terminate-Ack             sta = Send-Terminate-Ack
-
-   RUC  = Receive-Unknown-Code              scj = Send-Code-Reject
-   RXJ+ = Receive-Code-Reject (permitted)
-       or Receive-Protocol-Reject
-   RXJ- = Receive-Code-Reject (catastrophic)
-       or Receive-Protocol-Reject
-*/
+ * Events                                   Actions
+ * TO+  = Timeout with counter > 0          irc = Initialize-Restart-Count
+ * TO-  = Timeout with counter expired      zrc = Zero-Restart-Count
+ * RCR+ = Receive-Configure-Request (Good)  scr = Send-Configure-Request
+ * RCR- = Receive-Configure-Request (Bad)
+ * RCA  = Receive-Configure-Ack             sca = Send-Configure-Ack
+ * RCN  = Receive-Configure-Nak/Rej         scn = Send-Configure-Nak/Rej
+ * RTR  = Receive-Terminate-Request         str = Send-Terminate-Request
+ * RTA  = Receive-Terminate-Ack             sta = Send-Terminate-Ack
+ * RUC  = Receive-Unknown-Code              scj = Send-Code-Reject
+ * RXJ+ = Receive-Code-Reject (permitted)
+ *     or Receive-Protocol-Reject
+ * RXJ- = Receive-Code-Reject (catastrophic)
+ *     or Receive-Protocol-Reject
+ */
 static int cp_table[EVENTS][STATES] = {
 	/* CLOSED     STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
-	     0           1         2       3       4      5          6    */
+	 *   0           1         2       3       4      5          6
+	 */
 	{IRC|SCR|3,     INV     , INV ,   INV   , INV ,  INV    ,   INV   }, /* START */
 	{   INV   ,      0      ,  0  ,    0    ,  0  ,   0     ,    0    }, /* STOP */
 	{   INV   ,     INV     ,STR|2,  SCR|3  ,SCR|3,  SCR|5  ,   INV   }, /* TO+ */
@@ -294,9 +292,10 @@ static int cp_table[EVENTS][STATES] = {
 };
 
 /* SCA: RCR+ must supply id, len and data
-   SCN: RCR- must supply code, id, len and data
-   STA: RTR must supply id
-   SCJ: RUC must supply CP packet len and data */
+ * SCN: RCR- must supply code, id, len and data
+ * STA: RTR must supply id
+ * SCJ: RUC must supply CP packet len and data
+ */
 static void ppp_cp_event(struct net_device *dev, u16 pid, u16 event, u8 code,
 			 u8 id, unsigned int len, const void *data)
 {
-- 
2.8.1