linux-kernel - Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef1a9a97e0238a0ff2d8e044487602a5@mailhost.ics.forth.gr>
Date:   Wed, 16 Jun 2021 13:43:32 +0300
From:   Nick Kossifidis <mick@....forth.gr>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Nick Kossifidis <mick@....forth.gr>,
        Rob Herring <robh+dt@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Frank Rowand <frowand.list@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling

Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:
> 
> I can't comment on the duplication on arm64, but to me, /chosen
> sounds like the natural place for both "linux,elfcorehdr" and
> "linux,usable-memory-range".  First rule of DT is "DT describes
> hardware, not software policy", with /chosen describing some software
> configuration.
> 

We already have "linux,usable-memory" on /memory node:
https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
and it makes perfect sense to be there since it overrides /memory's reg 
property.

Why define another binding for the same thing on /chosen ?

> 
> OK, thanks!
> But do you need the entry on the reservation map?
> 

I'll add the entry from kexec-tools, so that the kernel will reserve the 
region as part of:
https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L605