linux-kernel - Re: [PATCH -next] platform/x86: think-lmi: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be89ca5c-3484-6d02-440f-8dc89297e48b@gmail.com>
Date:   Wed, 16 Jun 2021 13:20:48 +0200
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Zou Wei <zou_wei@...wei.com>, markpearson@...ovo.com,
        hdegoede@...hat.com, mgross@...ux.intel.com
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] platform/x86: think-lmi: Add missing
 MODULE_DEVICE_TABLE

On 6/16/21 4:50 AM, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   drivers/platform/x86/think-lmi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
> index 7771c93..6e1fbc4 100644
> --- a/drivers/platform/x86/think-lmi.c
> +++ b/drivers/platform/x86/think-lmi.c
> @@ -873,6 +873,7 @@ static const struct wmi_device_id tlmi_id_table[] = {
>   	{ .guid_string = LENOVO_BIOS_SETTING_GUID },
>   	{ }
>   };
> +MODULE_DEVICE_TABLE(vmi, tlmi_id_table);

I assume this should be "wmi", i.e.

     MODULE_DEVICE_TABLE(wmi, tlmi_id_table);

instead of "vmi"?

Regards,
Max

>   
>   static struct wmi_driver tlmi_driver = {
>   	.driver = {
>